[FFmpeg-devel] [PATCH] avcodec/scpr3: add missing check for decode_value3() return value

[Carl Eugen Hoyos]

2019-04-26 17:31 GMT+02:00, James Almer <jamrial at gmail.com>:
> Fixes ticket #7866.
>
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
>  libavcodec/scpr3.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/libavcodec/scpr3.c b/libavcodec/scpr3.c
> index f92ccfa902..5cfad9f4d2 100644
> --- a/libavcodec/scpr3.c
> +++ b/libavcodec/scpr3.c
> @@ -1038,6 +1038,9 @@ static int decompress_p3(AVCodecContext *avctx,
>                           s->range_model3.freqs[1],
>                           s->range_model3.cnts,
>                           s->range_model3.dectab, &temp);
> +    if (ret < 0)
> +        return ret;
> +
>      min += temp << 8;

Why is it a problem to access an uninitialized value?

Carl Eugen