[FFmpeg-devel] [PATCH 1/3] avutil/pixfmt: Add EBU Tech. 3213-E AVColorPrimaries value
Raphaƫl Zumer
rzumer at tebako.net
Fri Aug 9 15:31:59 EEST 2019
On 2019-08-09 7:51 a.m., Vittorio Giovara wrote:
> this value was already present, this is just a rename
I think it counts as a new enum value (variant), even though it aliases
another.
I initially wrote "rename", but reworded the commit message based on
James Almer's comment:
> The subject should be something like "avutil/pixfmt:
> Add EBU Tech. 3213-E AVColorPrimaries value"
> I'd do the opposite, similarly to what is done for AVCOL_PRI_SMPTEST428_1
>
> AVCOL_PRI_EBU3213 = 22, ///< JEDEC P22 phosphors, EBU Tech 3213 E
> AVCOL_PRI_JEDEC_P22 = AVCOL_PRI_EBU3213,
>
> AVCOL_PRI_NB ///< Not part of ABI
> };
Will do. I will also replace internal usage of JEDEC_P22 with EBU3213
elsewhere.
I just noticed I missed the same comment (and a few others) in JA's
review earlier, sorry about that. Will apply all corrections in my next
revision.
More information about the ffmpeg-devel
mailing list