[FFmpeg-devel] [PATCH v2] avformat/mxfenc: fix warning: unused function 'klv_ber_length' [-Wunused-function]

[Tomas Härdin]

tor 2019-08-29 klockan 16:44 +0800 skrev lance.lmwang at gmail.com:
> From: Limin Wang <lance.lmwang at gmail.com>
> 
> Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
> ---
>  libavformat/mxfenc.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
> index 8b3d599a6f..aa23ee3947 100644
> --- a/libavformat/mxfenc.c
> +++ b/libavformat/mxfenc.c
> @@ -553,15 +553,14 @@ static int klv_ber_length(uint64_t len)
>  static int klv_encode_ber_length(AVIOContext *pb, uint64_t len)
>  {
>      // Determine the best BER size
> -    int size;
> -    if (len < 128) {
> +    int size = klv_ber_length(len);
> +    if (size == 1) {
>          //short form
>          avio_w8(pb, len);
>          return 1;
>      }
>  
> -    size = (av_log2(len) >> 3) + 1;
> -
> +    size --;

Looks good to me. I'll push some time this weekend unless someone
objects

/Tomas