[FFmpeg-devel] [PATCH 2/3] avcodec/libx265: add a qp option and apply the relevant global AVCodecContext settings to the encoder context

[Michael Niedermayer]

On Sun, Dec 29, 2019 at 10:17:48AM -0300, James Almer wrote:
> On 12/29/2019 8:53 AM, Michael Niedermayer wrote:
> > On Sat, Dec 28, 2019 at 08:55:13PM -0300, James Almer wrote:
> >> Signed-off-by: James Almer <jamrial at gmail.com>
> >> ---
> >>  doc/encoders.texi    | 22 ++++++++++++++++++++++
> >>  libavcodec/libx265.c | 28 ++++++++++++++++++++++++++++
> >>  2 files changed, 50 insertions(+)
> > 
> > breaks build here, i susupect missing libx265 version check ...
> > 
> > CC	libavcodec/libx265.o
> > libavcodec/libx265.c: In function ‘libx265_encode_init’:
> > libavcodec/libx265.c:237:24: error: ‘struct <anonymous>’ has no member named ‘qpMin’
> >          ctx->params->rc.qpMin = avctx->qmin;
> >                         ^
> > libavcodec/libx265.c:239:24: error: ‘struct <anonymous>’ has no member named ‘qpMax’
> >          ctx->params->rc.qpMax = avctx->qmax;
> >                         ^
> > libavcodec/libx265.c:241:20: error: request for member ‘rc’ in something not a structure or union
> >          ctx->params.rc.qpStep = avctx->max_qdiff;
> >                     ^
> 
> Is this a distro provided libx265? The commit that added these fields is
> three and a half years old by now.

no, it just wasnt updated since a long time.

Thanks


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20191229/57149c09/attachment.sig>