[FFmpeg-devel] [PATCH V5 2/2] avcodec/libx264: add support for ROI-based encoding

Guo, Yejun yejun.guo at intel.com
Mon Jan 7 08:58:40 EET 2019



> -----Original Message-----
> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf
> Of Moritz Barsnick
> Sent: Friday, January 04, 2019 7:58 PM
> To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH V5 2/2] avcodec/libx264: add support
> for ROI-based encoding
> 
> On Fri, Jan 04, 2019 at 00:35:43 +0800, Guo, Yejun wrote:
> > @@ -345,6 +350,50 @@ static int X264_frame(AVCodecContext *ctx,
> > AVPacket *pkt, const AVFrame *frame,
> [...]
> > +        if (sd) {
> > +            if (x4->params.rc.i_aq_mode == X264_AQ_NONE) {
> > +                av_log(ctx, AV_LOG_WARNING, "Adaptive quantization must be
> enabled to use ROI encoding, skipping ROI.\n");
> > +            } else {
> > +                if (frame->interlaced_frame == 0) {
> [...]
> > +                } else {
> > +                    av_log(ctx, AV_LOG_WARNING, "interlaced_frame not
> supported for ROI encoding yet, skipping ROI.\n");
> > +                }
> 
> Are these warnings given on every frame, if applicable? If so, that may give a
> lot of console spam.

yes, it acts so, just like the av_log in function reconfig_encoder in the same file.

looks it is not good, I'll add a flag to print only once.

> 
> Moritz
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


More information about the ffmpeg-devel mailing list