[FFmpeg-devel] [PATCH 1/2] avcodec: add HCOM decoder

Paul B Mahol onemda at gmail.com
Mon Jan 14 21:32:39 EET 2019


On 1/6/19, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> 2019-01-03 0:51 GMT+01:00, Rostislav Pehlivanov <atomnuker at gmail.com>:
>> On Wed, 2 Jan 2019 at 19:02, Paul B Mahol <onemda at gmail.com> wrote:
>
>
>>> +        while (bits-- > 0) {
>>> +
>>> +            if (current & 0x80000000) {
>>> +                s->dict_entry = s->dict[s->dict_entry].r;
>>> +            } else {
>>> +                s->dict_entry = s->dict[s->dict_entry].l;
>>> +            }
>>
>> No need for brackets here.
>
> Fwiw, I believe these brackets are useful.
> But that may only be me debugging.
>

Locally fixed. Will apply ASAP!

This work is being sponsored by N. G. with 10 $.


More information about the ffmpeg-devel mailing list