[FFmpeg-devel] [PATCH 2/5] swscale/swscale_unscaled: add missing gbrap10 on ff_get_unscaled_swscale

[Muhammad Faiz]

On Mon, Jan 28, 2019 at 2:52 AM Michael Niedermayer
<michael at niedermayer.cc> wrote:
>
> On Sun, Jan 27, 2019 at 04:36:16PM +0700, Muhammad Faiz wrote:
> > Fix inconsistent checksums between gbrap10be
> > and gbrap10le on fate-filter-pixfmts.
> >
> > Signed-off-by: Muhammad Faiz <mfcc64 at gmail.com>
> > ---
> >  libswscale/swscale_unscaled.c            | 3 +++
> >  tests/ref/fate/filter-pixfmts-copy       | 2 +-
> >  tests/ref/fate/filter-pixfmts-crop       | 2 +-
> >  tests/ref/fate/filter-pixfmts-field      | 2 +-
> >  tests/ref/fate/filter-pixfmts-fieldorder | 2 +-
> >  tests/ref/fate/filter-pixfmts-hflip      | 2 +-
> >  tests/ref/fate/filter-pixfmts-il         | 2 +-
> >  tests/ref/fate/filter-pixfmts-null       | 2 +-
> >  tests/ref/fate/filter-pixfmts-transpose  | 2 +-
> >  tests/ref/fate/filter-pixfmts-vflip      | 2 +-
> >  10 files changed, 12 insertions(+), 9 deletions(-)
> >
> > diff --git a/libswscale/swscale_unscaled.c b/libswscale/swscale_unscaled.c
> > index 058f2b94db..9abfae5c04 100644
> > --- a/libswscale/swscale_unscaled.c
> > +++ b/libswscale/swscale_unscaled.c
> > @@ -1942,6 +1942,7 @@ void ff_get_unscaled_swscale(SwsContext *c)
> >           dstFormat == AV_PIX_FMT_GBRP12LE || dstFormat == AV_PIX_FMT_GBRP12BE ||
> >           dstFormat == AV_PIX_FMT_GBRP14LE || dstFormat == AV_PIX_FMT_GBRP14BE ||
> >           dstFormat == AV_PIX_FMT_GBRP16LE || dstFormat == AV_PIX_FMT_GBRP16BE ||
> > +         dstFormat == AV_PIX_FMT_GBRAP10LE || dstFormat == AV_PIX_FMT_GBRAP10LE ||
> >           dstFormat == AV_PIX_FMT_GBRAP12LE || dstFormat == AV_PIX_FMT_GBRAP12BE ||
> >           dstFormat == AV_PIX_FMT_GBRAP16LE || dstFormat == AV_PIX_FMT_GBRAP16BE ))
> >          c->swscale = Rgb16ToPlanarRgb16Wrapper;
>
> > @@ -1951,6 +1952,7 @@ void ff_get_unscaled_swscale(SwsContext *c)
> >           srcFormat == AV_PIX_FMT_GBRP10LE || srcFormat == AV_PIX_FMT_GBRP10BE ||
> >           srcFormat == AV_PIX_FMT_GBRP12LE || srcFormat == AV_PIX_FMT_GBRP12BE ||
> >           srcFormat == AV_PIX_FMT_GBRP14LE || srcFormat == AV_PIX_FMT_GBRP14BE ||
> > +         dstFormat == AV_PIX_FMT_GBRAP10LE || dstFormat == AV_PIX_FMT_GBRAP10LE ||
> >           srcFormat == AV_PIX_FMT_GBRAP12LE || srcFormat == AV_PIX_FMT_GBRAP12BE ||
> >           srcFormat == AV_PIX_FMT_GBRAP16LE || srcFormat == AV_PIX_FMT_GBRAP16BE) &&
>
> this looks a bit strange, the added line adds a dstFormat check into a list of
> srcFormat checks, also the check is added twice

My bad. Will fix it.

Thx.