[FFmpeg-devel] [PATCH] avformat/mpegts: respect program number when merging streams

Marton Balint cus at passwd.hu
Fri Jul 12 22:33:16 EEST 2019



On Tue, 9 Jul 2019, Aman Gupta wrote:

> On Tue, Jul 9, 2019 at 2:07 PM Marton Balint <cus at passwd.hu> wrote:
>
>> merge_pmt_versions was not usable if multiple programs were present because
>> when it was searching for candidate streams it did not make sure that the
>> PMT was
>> of the same program. This caused the streams of all programs to get merged
>> into
>> a single (garbled) program.
>>
>> This patch makes sure that the program number (service ID) is also matching
>> with the old streams when parsing the PMT making the feature useful for
>> multi
>> program streams.
>>
>> This change might cause issues for single program streams if the program
>> number
>> changes as well, but I think it is acceptable because the goal of the
>> option is
>> to make the parsing resilient to PID changes, and that is still working as
>> expected.
>>
>
> Patch looks good to me. Thanks for catching this!

Thanks, applied.

Regards,
Marton


More information about the ffmpeg-devel mailing list