[FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: use -reinit_filter to disable/enable auto scale

Eoff, Ullysses A ullysses.a.eoff at intel.com
Sat Jul 13 07:25:59 EEST 2019


> > > Add an option to disable/enable "auto insert" is Ok for me, but I
> > > think if you reuse the -reinit_filter option, you need to update doc
> > > part at the same time.
> >
> > I prefer to add a separate option, too.
> > Depending on the comments, I'll either update doc for reinit_filter, or add a
> > new option and related doc.
> 
> Since there is an existed option named "autorotate", add an new option "autoscale" looks can keep tune.

I like the idea of having a new option, too.  The option name "reinit_filter" doesn't imply anything
about "scaling"... it's just a side-effect.  That is, reinit_filter could cause other filters to behave
differently too, right?  So an explicit option to enable/disable auto scale would imply a more
obvious expectation to the user.

U. Artie



More information about the ffmpeg-devel mailing list