[FFmpeg-devel] [PATCH] libavformat/subfile: Fix SEEK_CUR and SEEK_END seeking

Michael Niedermayer michael at niedermayer.cc
Thu Jul 18 23:04:47 EEST 2019


On Wed, Jul 17, 2019 at 07:45:00PM +0000, Andreas Rheinhardt wrote:
> Michael Niedermayer:
> > On Mon, Jul 15, 2019 at 07:48:35PM +0200, Andreas Rheinhardt wrote:
> >> Up until now, when performing a SEEK_END seek, the subfile protocol
> >> ignored the desired position (relative to EOF) and used the current
> >> absolute offset in the input file instead.
> > 
> > I think this comment is only intended to be in the previous patch
> > 
> > [...]
> No, the new patch supersedes the previous patch and therefore the
> commit message explains what is wrong with SEEK_END as well as with
> SEEK_CUR. Or do you want the changes to be split in two commits?

ahh, ok, sorry, i had looked at the code after locally applying
both which worked and caused the hunk to be not in the 2nd
so what i looked at was different from what you posted to the ML

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190718/aaaba724/attachment.sig>


More information about the ffmpeg-devel mailing list