[FFmpeg-devel] [PATCH v15 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

[Sun, Jing A]

-----Original Message-----
From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf Of Li, Zhong
Sent: Tuesday, July 30, 2019 3:49 PM
To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v15 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

> > +AVCodec ff_libsvt_hevc_encoder = {
> > +    .name           = "libsvt_hevc",
> > +    .long_name      = NULL_IF_CONFIG_SMALL("SVT-HEVC(Scalable
> Video Technology for HEVC) encoder"),
> > +    .priv_data_size = sizeof(SvtContext),
> > +    .type           = AVMEDIA_TYPE_VIDEO,
> > +    .id             = AV_CODEC_ID_HEVC,
> > +    .init           = eb_enc_init,
> > +    .encode2        = eb_encode_frame,
> > +    .close          = eb_enc_close,
> > +    .capabilities   = AV_CODEC_CAP_DELAY |
> AV_CODEC_CAP_AUTO_THREADS,
> 
> The code don't support to configure thread_count, so I think you'll 
> get the same result without AV_CODEC_CAP_AUTO_THREADS.

> This was pointed out by Mark Thompson on patch V4. 
> It is a problem how comment can be well addressed and avoid to be pointed out again and again. 

I got started based on V5 and V6 is my first submission. Thanks for showing me the information. I am looking into it. 

Regards,
Sun, Jing