[FFmpeg-devel] [PATCH v3] ffprobe: Fix memory leak

James Almer jamrial at gmail.com
Fri Jun 21 18:09:44 EEST 2019


On 6/21/2019 11:41 AM, Derek Buitenhuis wrote:
> This packet was not necessarily unreferenced.
> 
> Signed-off-by: Derek Buitenhuis <derek.buitenhuis at gmail.com>
> ---
>  fftools/ffprobe.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
> index 3becb6330e..5aaddb0308 100644
> --- a/fftools/ffprobe.c
> +++ b/fftools/ffprobe.c
> @@ -2429,9 +2429,7 @@ static int read_interval_packets(WriterContext *w, InputFile *ifile,
>          }
>          av_packet_unref(&pkt);
>      }
> -    av_init_packet(&pkt);
> -    pkt.data = NULL;
> -    pkt.size = 0;
> +    av_packet_unref(&pkt);
>      //Flush remaining frames that are cached in the decoder
>      for (i = 0; i < fmt_ctx->nb_streams; i++) {
>          pkt.stream_index = i;

LGTM.


More information about the ffmpeg-devel mailing list