[FFmpeg-devel] [PATCH] libavcodec/qsvenc: fix mpeg2 encoding

[Li, Zhong]

> > > Subject: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: fix mpeg2
> > > encoding Fixes bug #7839
> > > https://trac.ffmpeg.org/ticket/7839
> > > Supersedes:
> > > #12935 - https://patchwork.ffmpeg.org/patch/12935/
> > > #12872 - https://patchwork.ffmpeg.org/patch/12872/
> > > Regards.
> > > A.H.
> >
> > It was saidhttps://patchwork.ffmpeg.org/patch/12935/ could not fix
> #7839, how this one can work?
> 
> 
> I compiled your patch and doesn't work.
> My path works.

Glad to know it.

> The difference?
> In addition to a few extra little checks, It seems that the
> QSV_RUNTIME_VERSION_ATLEAST(q->ver, 1, 11) check fails every time in
> Windows (almost in my environment).

If QSV_RUNTIME_VERSION_ATLEAST(q->ver, 1, 11) always equal to zero, then co3 won't be set, 
If codec is MPEG2, co3 won't be set too.
I can't see any difference for MPEG2 case.

> Futhermore, it has more sense to apply the check inside the conditional
> preprocessing of #if QSV_HAVE_CO3 and not outside.

Make sense, but no difference for run-time result? 

> As a summary: I confirm that my patch works. And it's based on your
> proposal. So please comment positively to merge it.

It is closer to be merged, but need to confirm which exact line of code make difference.
(Your verification on Windows was appreciated.)

> Thank you!
> A.H.