[FFmpeg-devel] [PATCH] libavformat/qsvenc: repeat mpeg2 missing headers [v2]

[Reimar Döffinger]

On 28.05.2019, at 12:48, Andreas Håkon <andreas.hakon at protonmail.com> wrote:

> Hi,
> 
> This patch supersedes #13105 (https://patchwork.ffmpeg.org/patch/13105/)
> 
> A new (simpler and more robust) implementationof of the reinsertion of the
> missing headers in the MPEG-2 bitstream from the HW QSV encoder.
> 
> The problem is quite simple: The bitstream generated by the MPEG-2 QSV
> encoder only incorporates the SEQ_START_CODE and EXT_START_CODE
> headers in the first GOP. This generates a result that is not suitable for
> streaming or broadcasting.
> With this patch the "mpeg2_qsv" encoder is at the same level as the
> "mpeg2video", as the software implementation repeats these headers by default
> in each GOP.

I am sure I might be missing things, but I would think that this is only necessary
when muxing into certain containers.
I.e. I would think when muxing the stream into .mov, .mkv or .nut files your patch
would only needlessly bloat the size.
I admit this also applies to the native mpeg2 encoder, so this might be a design issue
in FFmpeg, but it's the background why it feels a bit wrong to do it in the encoder...

> 
> Regards.
> A.H.
> 
> ---
> <0001-libavformat-qsvenc-repeat-mpeg2-missing-headers-v2.patch.txt>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".