[FFmpeg-devel] [PATCH v1] avformat/utils: Fixes misdetection of zYLx.wav

[Hendrik Leppkes]

On Wed, Nov 6, 2019 at 10:01 AM <lance.lmwang at gmail.com> wrote:
>
> From: Limin Wang <lance.lmwang at gmail.com>
>
> Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
> ---
>  libavformat/utils.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/libavformat/utils.c b/libavformat/utils.c
> index 8196442dd1..8381498e2b 100644
> --- a/libavformat/utils.c
> +++ b/libavformat/utils.c
> @@ -367,8 +367,7 @@ static int set_codec_from_probe_data(AVFormatContext *s, AVStream *st,
>                 fmt->name, score);
>          for (i = 0; fmt_id_type[i].name; i++) {
>              if (!strcmp(fmt->name, fmt_id_type[i].name)) {
> -                if (fmt_id_type[i].type != AVMEDIA_TYPE_AUDIO &&
> -                    st->codecpar->sample_rate)
> +                if (st->codecpar->sample_rate)
>                      continue;
>                  if (st->request_probe > score &&
>                      st->codecpar->codec_id != fmt_id_type[i].id)

This change seems wrong, as you are practically rejecting probing of
any audio now, since those would get a sample rate.

- Hendrik