[FFmpeg-devel] [PATCH v2] avfilter: Add tonemap vaapi filter for H2S

[Carl Eugen Hoyos]

Am Do., 28. Nov. 2019 um 07:56 Uhr schrieb Song, Ruiling
<ruiling.song at intel.com>:

> > > Am 28.11.2019 um 06:37 schrieb Sun, Xinpeng <xinpeng.sun at intel.com>:
> > >
> > >>>
> > >>> +    if (input_frame->color_trc != AVCOL_TRC_SMPTE2084) {
> > >>> +        av_log(avctx, AV_LOG_ERROR, "Only support HDR10 as input for
> > vaapi tone-mapping\n");
> > >>> +        return AVERROR(EINVAL);
> > >>
> > >> Shouldn't this also accept unknown trc?
> > >> (With a warning)
> > >
> > > Sorry if I misunderstand "unknown trc". Did you mean the trc undefined by
> > ffmpeg or the trc unsupported by the driver?
> >
> > My question is:
> > If input_frame->color_trc is AVCOL_TRC_UNSPECIFIED, will the above fail?
> > But shouldn’t the user be able to use the filter in this case?
>
> I am not sure if assuming the input is using SMPTE2084 sounds more acceptable
> in case of unspecified? If yes, I think we can change as you suggested.

(Me neither.)
A warning could be shown instead of failing.

Carl Eugen