[FFmpeg-devel] [PATCH] [GSOC] libavfilter/vf_colorconstancy.c : Adding weighted greyedge

[YATENDRA SINGH]

>
> As Michael noted, please resend without broken like feeds. I can't read
> most of the diff the way it is now.
>
> Sorry but I could not understand what broken by newlines mean. Can you
explain a little bit further?


> Documentation update missing (and eventually changelog).
>
Is this documentation supposed to be different from the autogenerated one
for the functions that I have placed?


> > +#if CONFIG_WEIGHTED_GREYEDGE_FILTER
> Shouldn't sections of your code also be disabled if this is not set,
> not only the options? And intermingled with #if CONFIG_GREYEDGE_FILTER?
>
> The specific parts of the code activated based on the filter name, and if
the filter is not set, wouldn't it be impossible to call that filter?

Also git send-email is not working for some reason and I am always stuck on
the same SMTP error, so I have attached the patch updated based on the
suggestions.
Please point out any mistakes I may have made as I do not have much
experience in submitting work through patches.

Regards,
Yatendra Singh.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: adding_weighted_greyedge.patch
Type: text/x-patch
Size: 13212 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200416/c49cef56/attachment.bin>