[FFmpeg-devel] [PATCH 6/9] lavfi/vf_pp: convert to the video_enc_params API

[Michael Niedermayer]

On Sat, Apr 18, 2020 at 07:03:16PM +0200, Marton Balint wrote:
> 
> 
> On Sat, 18 Apr 2020, Michael Niedermayer wrote:
> 
> >On Sat, Apr 18, 2020 at 12:14:12PM +0200, Anton Khirnov wrote:
> >[...]
> >>diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak
> >>index 3d0d4969b8..cb7ce7a158 100644
> >>--- a/tests/fate/filter-video.mak
> >>+++ b/tests/fate/filter-video.mak
> >>@@ -535,7 +535,7 @@ FATE_FILTER_PP = fate-filter-pp fate-filter-pp1 fate-filter-pp2 fate-filter-pp3
> >> FATE_FILTER_VSYNTH-$(CONFIG_PP_FILTER) += $(FATE_FILTER_PP)
> >> $(FATE_FILTER_PP): fate-vsynth1-mpeg4-qprd
> >>
> >>-fate-filter-pp:  CMD = framecrc -flags bitexact -idct simple -i $(TARGET_PATH)/tests/data/fate/vsynth1-mpeg4-qprd.avi -frames:v 5 -flags +bitexact -vf "pp=be/hb/vb/tn/l5/al"
> >>+fate-filter-pp:  CMD = framecrc -flags bitexact -export_side_data venc_params -idct simple -i $(TARGET_PATH)/tests/data/fate/vsynth1-mpeg4-qprd.avi -frames:v 5 -flags +bitexact -vf "pp=be/hb/vb/tn/l5/al"
> >
> >ffmpeg / ffplay should automatically enable the exportation of the parameters
> >when theres a filter downstream that needs such parameters
> >
> >Otherwise the use of these filters (and other filters that need any kind of
> >information thats unavailable by default) would become a bit akward to use
> 
> Why? It is not unusual at all that you need to specify certain extra
> parameters to export some kind of metadata. 

in addition to what carl said.
It seems you consider that "normal", i wouldnt really consider it normal
to have to specify this by hand.
All the information is there for the code to do this automatically and its
not really a A vs B alternative. Instead "-export_side_data venc_params"
with a filter using this afterwards is the only functional choice

And this is not just useful here there are other situations where this
is useful as you said "not unusual at all that you need to specify certain
extra parameters to export some kind of metadata"

IMHO, let the machiene do this kind of work not the user

Thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200418/a05b9e12/attachment.sig>