[FFmpeg-devel] [PATCH 2/3] oggdec: verify page checksum

[Lynne]

Apr 29, 2020, 16:00 by michael at niedermayer.cc:

> On Tue, Apr 28, 2020 at 07:22:08PM +0200, Lynne wrote:
>
>> Apr 28, 2020, 16:07 by dev at lynne.ee:
>>
>> > Apr 28, 2020, 15:59 by mattias.wadman at gmail.com:
>> >
>> >>
>> >>
>> > Well, I consider CRC checking a part of correctly parsing ogg, so I think its best to leave it on
>> > all the time.
>> >
>>
>> Did a new version of the patches.
>> The first two are identical, save for some minor style tweaks.
>> The last one now ensures the max page size, 65k, is available for seeking and speeds up
>> decoding on new/replacement streams since the offset was incorrect.
>> I think its worth it.
>>
>> I'm also close to figuring out how to make chained Opus work, will send a patch once I do.
>>
>
> This patchset seems to detect a crc error in:
> Your patchset is probably correct in this as there are artifacts before, 
> just reporting this as i noticed it.
>
> ./ffmpeg -i ~/tickets/2121/vlc-bug.oga c.wav
>
> sample should be here: https://trac.ffmpeg.org/raw-attachment/ticket/2121/vlc-bug.oga
>
> thanks
>

Thanks, checked the sample, it seems corrupt so patch is working as intended.
I plan to push the patchset tonight, unless someone has comments or reviews.