[FFmpeg-devel] [PATCH v6 1/4] lavc: add FLIF decoding support

[Nicolas George]

Moritz Barsnick (12020-08-27):
> I understand this justification. I just wanted to point out that the
> code was not parsable to my brain, due to the macros (which I do
> relaize have "goto"s in them, which is okay to me) and the "case"
> labels in the middle of code blocks.
> 
> I suggest others comment on this as well.

I agree with you, it makes the code very hard to read. Maybe having a
real state engine, with clear dispatching and all variables in the
context takes a little more effort short-term, but in the long run it
will make things much easier to maintain.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200827/3631b10f/attachment.sig>