[FFmpeg-devel] [PATCH 2/2] avformat/voc_packet: Add a basic check on max_size
Michael Niedermayer
michael at niedermayer.cc
Sat Dec 12 13:38:44 EET 2020
Fixes: signed integer overflow: -2147483648 - 4 cannot be represented in type 'int'
Fixes: 28127/clusterfuzz-testcase-minimized-ffmpeg_dem_VOC_fuzzer-4880586455646208
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
libavformat/voc_packet.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavformat/voc_packet.c b/libavformat/voc_packet.c
index 1e2e19e1c3..3492227deb 100644
--- a/libavformat/voc_packet.c
+++ b/libavformat/voc_packet.c
@@ -44,6 +44,8 @@ ff_voc_get_packet(AVFormatContext *s, AVPacket *pkt, AVStream *st, int max_size)
AVINDEX_KEYFRAME);
while (!voc->remaining_size) {
+ if (max_size < 4)
+ return AVERROR_INVALIDDATA;
type = avio_r8(pb);
if (type == VOC_TYPE_EOF)
return AVERROR_EOF;
--
2.17.1
More information about the ffmpeg-devel
mailing list