[FFmpeg-devel] [FFmpeg-cvslog] avcodec/dpx: fix use of uninitialised value

[James Almer]

On 12/18/2020 6:22 PM, Andriy Gelman wrote:
> On Fri, 18. Dec 18:22, James Almer wrote:
>> ffmpeg | branch: master | James Almer <jamrial at gmail.com> | Fri Dec 18 14:31:47 2020 -0300| [20b09b20a942d4aad38f9fa1324b713168d3db9a] | committer: James Almer
>>
>> avcodec/dpx: fix use of uninitialised value
>>
>> Found by Valgrind.
>>
>> Reviewed-by: Paul B Mahol <onemda at gmail.com>
>> Signed-off-by: James Almer <jamrial at gmail.com>
>>
>>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=20b09b20a942d4aad38f9fa1324b713168d3db9a
>> ---
>>
>>   libavcodec/dpx.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/libavcodec/dpx.c b/libavcodec/dpx.c
>> index bd431ccbcb..12bc165415 100644
>> --- a/libavcodec/dpx.c
>> +++ b/libavcodec/dpx.c
>> @@ -333,10 +333,12 @@ static int decode_frame(AVCodecContext *avctx,
>>           break;
>>       case 50: // RGB
>>           elements = 3;
>> +        yuv = 0;
>>           break;
>>       case 52: // ABGR
>>       case 51: // RGBA
>>           elements = 4;
>> +        yuv = 0;
>>           break;
>>       case 100: // UYVY422
>>           elements = 2;
> 
> Needs a fate update.
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/20201218173225.2652-1-jamrial@gmail.com/
> 
> The automated emails are getting blocked by gmail. I'll switch to a different mail server.
> 
> --
> Andriy

Fun, the test uses ffprobe but doesn't set a dependency for it, so it 
didn't recompile it. Should be fixed.

Either Harry Mallon or Paul should ensure the new output is correct, though.