[FFmpeg-devel] patch submission questions

Hongcheng Zhong sj.hc_Zhong at sjtu.edu.cn
Sun Jul 5 16:48:15 EEST 2020


On Sun, 2020-07-05 at 15:42 +0200, Manolis Stamatogiannakis wrote:
> Hello,
> 
> I'm trying to submit a patch for adding a "shift" option to
> subtitles/ass
> filters. Initial submission was ok, but resubmitting after addressing
> some
> emails didn't go as expected.
> 
> I have the following two questions on the process:
> 
> Q1: How do you get the "v2" label when you resubmit a patch? I
> thought this
> would happen auto-magically, but it didn't.
> And I couldn't find anything relevant in
> https://ffmpeg.org/developer.html#Contributing
> 
> Q2: In a patchset consisting of several commits, is each commit
> expected to
> be "standalone"? I.e. does it have to apply cleanly without depending
> on
> the previous commits in the patchset?
> Again this is not mentioned in the contributing guidelines, but my
> 2/3
> patch didn't make it to patchwork.ffmpeg.org, and this seems like a
> plausible explanation.
> 
> Thanks in advance,
> Manolis
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
You can use `git format-patch -v<n> -n<n>` to get patches like [PATCH
v2 1/20]. See git-format-patch documentation for more details.



More information about the ffmpeg-devel mailing list