[FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

[Fu, Linjie]

> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Eoff, Ullysses A
> Sent: Saturday, June 6, 2020 00:16
> To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale
> to disable/enable the default scale
> 
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Fu, Linjie
> > Sent: Friday, March 13, 2020 8:18 PM
> > To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale
> to disable/enable the default scale
> >
> > > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> > > Nicolas George
> > > Sent: Tuesday, February 18, 2020 03:02
> > > To: FFmpeg development discussions and patches <ffmpeg-
> > > devel at ffmpeg.org>
> > > Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -
> autoscale
> > > to disable/enable the default scale
> > >
> > > Gyan Doshi (12020-02-18):
> > > > Protection in the command line tool will help steer the user towards
> > > > choosing an accommodating encoder, which is possible once the flag
> and a
> > > > check is added.
> > >
> > > True, but minor and should not block the patch.
> > >
> >
> > Ping, thanks.
> >
> > - Linjie
> 
> Are all of the reviews addressed for this patch?  Is it ready to be merged, yet?
> 

Yes, and there are some discussions[1] previously about disabling autoscale, since
this may lead to undefined behavior in the pipeline.

And a possible solution is to define a capability[2] and add the capability check[3] to
restrict the usage and prevent the unexpected condition.


Please help to comment.

This choice is optional for user and many users are requesting for this.
Hence if no objections, I'd like to have this set step further.

Regards,
Linjie

[1] https://patchwork.ffmpeg.org/project/ffmpeg/patch/1564461924-4772-1-git-send-email-linjie.fu@intel.com/
[2] https://patchwork.ffmpeg.org/project/ffmpeg/patch/1582820025-22302-1-git-send-email-linjie.fu@intel.com/
[3] https://patchwork.ffmpeg.org/project/ffmpeg/patch/1582820043-22426-1-git-send-email-linjie.fu@intel.com/