[FFmpeg-devel] [PATCH 22/26] avformat/vplayerdec: Fix memleak upon read header failure
Andreas Rheinhardt
andreas.rheinhardt at gmail.com
Mon Jun 15 01:36:52 EEST 2020
The already parsed subtitles (contained in an FFDemuxSubtitlesQueue)
would leak if an error happened upon reading a subsequent subtitle.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
---
libavformat/vplayerdec.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavformat/vplayerdec.c b/libavformat/vplayerdec.c
index e3e7b4efb8..ca23ec76ac 100644
--- a/libavformat/vplayerdec.c
+++ b/libavformat/vplayerdec.c
@@ -83,8 +83,10 @@ static int vplayer_read_header(AVFormatContext *s)
AVPacket *sub;
sub = ff_subtitles_queue_insert(&vplayer->q, p, strlen(p), 0);
- if (!sub)
+ if (!sub) {
+ ff_subtitles_queue_clean(&vplayer->q);
return AVERROR(ENOMEM);
+ }
sub->pos = pos;
sub->pts = pts_start;
sub->duration = -1;
--
2.20.1
More information about the ffmpeg-devel
mailing list