[FFmpeg-devel] [PATCH] libavcodec/pgx: Added pgx decoder

Moritz Barsnick barsnick at gmx.net
Thu Jun 25 01:11:46 EEST 2020


On Wed, Jun 24, 2020 at 23:57:10 +0530, gautamramk at gmail.com wrote:
> +    const char *header_start = "PG ML ";

What about LM? Or do little-endian samples not exist?

> +    if (bytestream2_peek_byte(&s->g) == ' ')
> +        bytestream2_skip(&s->g, 1);

I understand the separators can also be tabs, but that might also not
be realistic. (I'm looking at the reference parser.) Same in
pgx_get_number().

> +static inline int write_frame_8(AVPacket *avpkt, AVFrame *frame, PGXContext * const s)

This is a bit similar to write_frame_16(). If a write_frame_16le() also
needs to be added, the three could perhaps be formed with macros.

Moritz


More information about the ffmpeg-devel mailing list