[FFmpeg-devel] [PATCH v4 1/2] libavcodec/pgxdec: Add PGX decoder

[Michael Niedermayer]

On Tue, Jun 30, 2020 at 08:31:39AM +0530, Gautam Ramakrishnan wrote:
> On Tue, Jun 30, 2020 at 5:49 AM Michael Niedermayer
> <michael at niedermayer.cc> wrote:
[...]
> >
> >
> > > +        if (temp > INT_MAX)
> > > +            return -1;
> > > +        ret = temp;
> > > +    }
> > > +
> > > +    if (ret >= 0)
> > > +        return ret;
> > > +    return -1;
> > > +}
> > > +
> >
> > > +static int ff_pgx_decode_header(AVCodecContext *avctx, PGXContext * s,
> >
> > why does this have a ff_ prefix ?
> I'll remove it. I was following pnmdec.c while writing this. Does the ff prefix
> indicate that it is a non-static function?

non statics need a ff, av, avpriv, ... prefix
each has a slightly different case to be used in,
see https://ffmpeg.org/developer.html#Naming-conventions

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

"I am not trying to be anyone's saviour, I'm trying to think about the
 future and not be sad" - Elon Musk

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200630/4929c5bd/attachment.sig>