[FFmpeg-devel] [PATCH 13/18] h264_sei: parse the picture timing SEIs correctly

[Michael Niedermayer]

On Mon, Mar 16, 2020 at 04:42:31PM -0300, James Almer wrote:
> On 3/16/2020 3:51 PM, Michael Niedermayer wrote:
> > On Fri, Mar 13, 2020 at 11:28:45AM +0100, Anton Khirnov wrote:
> >> Those SEIs refer to the currently active SPS. However, since the SEI
> >> NALUs precede the coded picture data in the bitstream, the active SPS is
> >> in general not known when we are decoding the SEI.
> >>
> >> Therefore, store the content of the picture timing SEIs and actually
> >> parse it when the active SPS is known.
> >> ---
> >>  libavcodec/h264_parser.c |  9 +++++
> >>  libavcodec/h264_sei.c    | 86 ++++++++++++++++++++++++----------------
> >>  libavcodec/h264_sei.h    | 11 +++++
> >>  libavcodec/h264_slice.c  | 10 +++++
> >>  4 files changed, 82 insertions(+), 34 deletions(-)
> > 
> > This seems to break fate
> > 
> > TEST    cbs-h264-CVSE2_Sony_B
> > --- ./tests/ref/fate/cbs-h264-CVSE2_Sony_B	2020-03-15 16:08:13.692521532 +0100
> > +++ tests/data/fate/cbs-h264-CVSE2_Sony_B	2020-03-16 19:50:23.164302663 +0100
> > @@ -1 +0,0 @@
> > -ca8bdba497bd2f3b97c50d59692eb537
> > Test cbs-h264-CVSE2_Sony_B failed. Look at tests/data/fate/cbs-h264-CVSE2_Sony_B.err for details.
> > tests/Makefile:250: recipe for target 'fate-cbs-h264-CVSE2_Sony_B' failed
> > make: *** [fate-cbs-h264-CVSE2_Sony_B] Error 1
> > 
> > thx
> 
> I can't reproduce this. Are you using a clean tree?

i had other patches in there, ill retest without tomorrow (too late now)
disregard my comment about there being an issue until i retest

thx


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200317/86c14cce/attachment.sig>