[FFmpeg-devel] [PATCH 2/2] Revert "avfilter/vf_framerate: if metadata lavfi.scd.mafd exists, we'll use it first"

lance.lmwang at gmail.com lance.lmwang at gmail.com
Fri May 15 02:09:07 EEST 2020


On Thu, May 14, 2020 at 11:51:29PM +0200, Marton Balint wrote:
> 
> 
> On Thu, 14 May 2020, Carl Eugen Hoyos wrote:
> 
> > Am Do., 14. Mai 2020 um 23:04 Uhr schrieb Marton Balint <cus at passwd.hu>:
> > > 
> > > This reverts commit 339593ca90cb3e05d659ec99a1479904ec742294.
> > > 
> > > Fixes null pointer dereference.
> > 
> > I did not look into the patches, and maybe you could add how the
> > null pointer dereferences are reproducible but if these patches fix
> > crashes, they should be pushed, other fixes can still be discussed.
> 
> Actual crashes depends on compiler and compiler options. I reproduced it
> with -O0, but if you take a look at FATE, you will see that there are
> multiple failures.

Sorry, LGTM, I think I have run make fate pass on both Mac and Linux 
x86 system. By the old email, this patchset have give comments and reviewed
so I push it after 12hour. I'm not clear about the rules, please update 
the developer document clearly. In fact, I'm glad to waiting your request
time if anybody request, just say "hold on".




> 
> Regards,
> Marton
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".

-- 
Thanks,
Limin Wang


More information about the ffmpeg-devel mailing list