[FFmpeg-devel] [PATCH v3] checkasm: add hscale test

Martin Storsjö martin at martin.st
Fri May 15 10:15:38 EEST 2020


On Thu, 14 May 2020, Josh de Kock wrote:

> This tests the hscale 8bpp to 14bpp functions with different filter
> sizes.

^ 8bpp to 14, and to 18, right?

> Signed-off-by: Josh de Kock <josh at itanimul.li>
> ---
>
> Adds support for checking corner cases for signed and large
> coefficients. Also makes the padded coefficients random data.
>
> Tested on x86_64 and aarch64.
>

> +                for (j = 0; j < width; j++) {
> +                    filter[i * width + j] = -((1 << 14) / (width - 1));
> +                }
> +                filter[i * width + (rnd() % (width - 1))] = ((1 << 15) - 1);

Actually, shouldn't this be i*width + (rnd() % width)?

LGTM with that addressed.

// Martin



More information about the ffmpeg-devel mailing list