[FFmpeg-devel] [PATCH 2/2] avfilter/vf_lut3d: prelut support for 3d cinespace luts

[Paul B Mahol]

On 5/22/20, Mark Reid <mindmark at gmail.com> wrote:
> On Thu, May 21, 2020 at 8:14 AM Paul B Mahol <onemda at gmail.com> wrote:
>
>> Probably ok, except code style.
>> Please keep code style consistent across files.
>>
>
> Thanks a lot for the feedback. I see a few inconsistently named variables,
> maybe I used too many spaces in places.  Could you tell me where is it that
> you have the most issue with? Did I name functions incorrectly or put them
> in bad locations?

Not enough spaces:

if()

should be

if ()

>
>
>> On 5/19/20, mindmark at gmail.com <mindmark at gmail.com> wrote:
>> > From: Mark Reid <mindmark at gmail.com>
>> >
>> > ---
>> >  libavfilter/vf_lut3d.c | 367 +++++++++++++++++++++++++++++++++++------
>> >  1 file changed, 312 insertions(+), 55 deletions(-)
>> >
>>
>