[FFmpeg-devel] [PATCH 4/4] avformat/mov: Stash mfra size if we're reading it anyway

[James Almer]

On 9/1/2020 12:49 PM, Derek Buitenhuis wrote:
> On 01/09/2020 16:36, James Almer wrote:
>> mfra_size in this function was an int32_t, so storing the output of
>> avio_rb32() could end up with a negative value.
>> It'll no longer be the case now that you made mfra_size in MOVContext an
>> uint32_t.
> 
> How was that ever valid in the first place, considering avio_rb32 returns an
> unsigned 32-bit integer?

How else would you read 32bit signed integers using AVIOContext function
helpers if not with avio_rb32()?

> 
> - Derek
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>