[FFmpeg-devel] [PATCH 2/2] avcodec/h264_parser: fix nalsize parser
Michael Niedermayer
michael at niedermayer.cc
Sat Aug 14 18:08:00 EEST 2021
Fixes: left shift of 16711968 by 8 places cannot be represented in type 'int'
Fixes: 36601/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-6581933285965824
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
libavcodec/h264_parser.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/h264_parser.c b/libavcodec/h264_parser.c
index d3c56cc188..22111c62a2 100644
--- a/libavcodec/h264_parser.c
+++ b/libavcodec/h264_parser.c
@@ -86,7 +86,7 @@ static int h264_find_frame_end(H264ParseContext *p, const uint8_t *buf,
int nalsize = 0;
i = next_avc;
for (j = 0; j < p->nal_length_size; j++)
- nalsize = (nalsize << 8) | buf[i++];
+ nalsize = ((unsigned)nalsize << 8) | buf[i++];
if (nalsize <= 0 || nalsize > buf_size - i) {
av_log(logctx, AV_LOG_ERROR, "AVC-parser: nal size %d remaining %d\n", nalsize, buf_size - i);
return buf_size;
--
2.17.1
More information about the ffmpeg-devel
mailing list