[FFmpeg-devel] [PATCH v18 01/19] avcodec, avutil: Move enum AVSubtitleType

[Soft Works]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Anton
> Khirnov
> Sent: Wednesday, December 1, 2021 2:35 PM
> To: ffmpeg-devel at ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v18 01/19] avcodec, avutil: Move enum
> AVSubtitleType
> 
> Quoting Soft Works (2021-11-29 20:47:52)
> > Signed-off-by: softworkz <softworkz at hotmail.com>
> > ---
> >  libavcodec/avcodec.h | 19 +--------------
> >  libavutil/subfmt.h   | 58 ++++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 59 insertions(+), 18 deletions(-)
> >  create mode 100644 libavutil/subfmt.h
> 
> This commit does way more than just moving the enum, it also
> deprecates existing enum values and adds new ones. That should be
> mentioned in the commit message and in doc/APIchanges.

This is something I would need some help with. Which of my commits should 
bump versions in which libs and where major or minor bump?

Here's what I _think_ (possibly wrong):
It's based on the V18 patchset


01/19 avcodec,avutil: Move enum AVSubtitleType to avutil, add new and

- major bump in avcodec because AVSubtitleType is removed
- major bump in avutil because AVSubtitleType is added

02/19 avutil/frame: Prepare AVFrame for subtitle handling

- major bump in avutil because AVFrame struct is modified
  (not just adding to the end)

03/19 avcodec/subtitles: Introduce new frame-based subtitle decoding

- minor bump in avcodec. New APIs are added, existing API remains functional

04/19 avfilter/subtitles: Update vf_subtitles to use new decoding api
(no change)

05/19 avcodec,avutil: Move ass helper functions to avutil as avpriv_ 

- major bump in avcodec and avutil
  no public APIs are changed but each lib depends on the other to be updated

06/19 avcodec/subtitles: Migrate subtitle encoders to frame-based API
(no change)
07/19 fftools/play,probe: Adjust for subtitle changes
(no change)
08/19 avfilter/subtitles: Add subtitles.c for subtitle frame allocation
(no change)

09/19 avfilter/avfilter: Handle subtitle frames

- minor bump in avfilter due to additions to the end of AVFilter struct.


No change for the remaining commits (18-19).


Does that make sense?

Thanks,
sw