[FFmpeg-devel] commits ecee6af8bd and 4ac869ca2a break build for macOS

[Helmut K. C. Tessarek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hello,

The following 2 commits break the build with a deployment target of 10.9 on
macOS.

I agree that 10.9 is quite old, but the rest of the code worked perfectly
fine, so were those 2 commits really necessary?

* 4ac869ca2a | 2021-12-18 11:57:31 -0800 | avfilter: add
vf_yadif_videotoolbox (Aman Karmani)
* ecee6af8bd | 2021-12-18 11:55:47 -0800 | avfilter: add metal utilities
(Aman Karmani)

Can you make that code conditional?


The error messages I get during the compile run are:

In file included from libavfilter/metal/utils.m:20:
./libavfilter/metal/utils.h:25:43: error: 'MTLDevice' is only available on
macOS 10.11 or newer [-Werror,-Wunguarded-availability]
void ff_metal_compute_encoder_dispatch(id<MTLDevice> device,
                                          ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/
Metal.framework/Headers/MTLCaptureScope.h:14:11:
note: 'MTLDevice' has been marked as being introduced in macOS
      10.11 here, but the deployment target is macOS 10.9.0
@protocol MTLDevice;
          ^
./libavfilter/metal/utils.h:25:6: note: annotate
'ff_metal_compute_encoder_dispatch' with an availability attribute to
silence this warning
void ff_metal_compute_encoder_dispatch(id<MTLDevice> device,
     ^
./libavfilter/metal/utils.h:26:43: error: 'MTLComputePipelineState' is only
available on macOS 10.11 or newer [-Werror,-Wunguarded-availability]
                                       id<MTLComputePipelineState> pipeline,
                                          ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/
Metal.framework/Headers/MTLArgumentEncoder.h:17:11:
note: 'MTLComputePipelineState' has been marked as being
      introduced in macOS 10.11 here, but the deployment target is macOS 10.9.
0
@protocol MTLComputePipelineState;
          ^

[snip - way too many messages to paste them all]

Cheers,
  K. C.

- -- 
regards Helmut K. C. Tessarek              KeyID 0x172380A011EF4944
Key fingerprint = 8A55 70C1 BD85 D34E ADBC 386C 1723 80A0 11EF 4944

/*
   Thou shalt not follow the NULL pointer for chaos and madness
   await thee at its end.
*/
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE191csiqpm8f5Ln9WvgmFNJ1E3QAFAmHA9hIACgkQvgmFNJ1E
3QB0aw//Wsns6KOrT2vlw3RWIyAS1dIrVHO3bBM7NAwl0lYbHkKM6wQpE5sVsSdq
tjAxWH+XikERU2jnHCCZqUormA40iei+WFXKAbZOgrobvrKMeXe/uuQaAmOL3Gkn
o5jvf1+v/Oh3Wd9rSYqdPu+b7VWyz0qj5y8jgBxPtrapfIBh35HBt/41JbVln/PY
d3+h+siAHuBUk1jLHTVep0qe5o3q+mB6m0As9bpGBoQD8oPhQvJxBMqzzzos3mOx
bgVA36NowZEiH8YpEXBMaHk8Ek6k1/37kexinvlRBCmk59mfACShfBJc8J0EC+ii
BVMF6OQvoQ3mHXT79fcd5xV7dueXzLGNAbaK+FQ7ZvAjQ2aEh7xVghH5I8hgRUKT
8JS1RS6e817+IsSlxFA0UvZ6waF/HINfUXpL0Ca4hFirFKSHRxaMIF/49EPgLk4g
mK/NSvNVIbEN6tpz0Kt0t3cvVEp0O5AoKPAwEuCTWa8io13hgHxlOX0TFMS+3d2A
CRuqROxEpAcOjYo92wWa/S1VFl4lDNBcxHnszA9sLRai7QTdxKmojoU+ti8PqTJa
iDoMVIiH4psyzMMqod7kas06w+KSnr7IyW3bKE50atUBY0P9BCqH1e7/mZ+gn0JM
ZSb61Lo9k0aYbHG7rTtXR4Wvtiao9NFCbD8NbHWPfrSRgs9jqP4=
=/fRX
-----END PGP SIGNATURE-----