[FFmpeg-devel] [PATCH 16/30] avcodec/mpegvideo_enc: Move updating mb_info to its only user

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Thu Dec 23 11:13:26 EET 2021


It is a H.263 option.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
---
There is unfortunately another call to update_mb_info()
that is not immediately followed (or preceded) by some ff_h263_*
function; otherwise one could have easily moved this to
a h263-specific place.

 libavcodec/mpegvideo_enc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c
index 79f67ca01b..0c98629603 100644
--- a/libavcodec/mpegvideo_enc.c
+++ b/libavcodec/mpegvideo_enc.c
@@ -2906,8 +2906,6 @@ static int encode_thread(AVCodecContext *c, void *arg){
                         }
                     }
 
-                    update_mb_info(s, 1);
-
                     switch(s->codec_id){
                     case AV_CODEC_ID_MPEG4:
                         if (CONFIG_MPEG4_ENCODER) {
@@ -2924,8 +2922,10 @@ static int encode_thread(AVCodecContext *c, void *arg){
                     break;
                     case AV_CODEC_ID_H263:
                     case AV_CODEC_ID_H263P:
-                        if (CONFIG_H263_ENCODER)
+                        if (CONFIG_H263_ENCODER) {
+                            update_mb_info(s, 1);
                             ff_h263_encode_gob_header(s, mb_y);
+                        }
                     break;
                     }
 
-- 
2.32.0



More information about the ffmpeg-devel mailing list