[FFmpeg-devel] [PATCH v2 3/3] avcodec/libx264: remove separate libx264rgb RGB wrapper

[Michael Niedermayer]

On Fri, Jul 02, 2021 at 02:25:13PM +0300, Jan Ekström wrote:
> No other encoder wrapper in libavcodec is split like this, and
> with RGB input this currently does not lead to 4:2:0 (which would
> be generally supported in most hardware and software implementations),
> but rather 4:4:4.
> 
> The libx262 encoder definition was not touched, as it already has
> 4:4:4 YCbCr defined for it, which as far as I can tell is not supported.
> ---
>  configure              |  2 --
>  doc/encoders.texi      |  7 ++++---
>  libavcodec/allcodecs.c |  1 -
>  libavcodec/libx264.c   | 43 ++++++------------------------------------
>  libavcodec/version.h   |  2 +-
>  5 files changed, 11 insertions(+), 44 deletions(-)

breaks:
./ffmpeg -i lena.pnm -vf format=bgr24 -vcodec libx264rgb  file-bgr.nut

also it breaks creating files which are playable on devices not supporting rgb
with a plain libx264 encoder selection

thx


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210702/4caae7fe/attachment.sig>