[FFmpeg-devel] [PATCH 1/6] lavf: improve AV_DISPOSITION_* doxy

[Tobias Rapp]

On 12/11/2021 17:32, Anton Khirnov wrote:
> Also switch the values definition to the (1 << N) style, which is easier
> to read.
> ---
>   libavformat/avformat.h | 96 +++++++++++++++++++++++++++++++++---------
>   1 file changed, 77 insertions(+), 19 deletions(-)
> 
> diff --git a/libavformat/avformat.h b/libavformat/avformat.h
> index a2af7e9f89..7d8ad08f07 100644
> --- a/libavformat/avformat.h
> +++ b/libavformat/avformat.h
> @@ -803,22 +803,56 @@ typedef struct AVIndexEntry {
>       int min_distance;         /**< Minimum distance between this and the previous keyframe, used to avoid unneeded searching. */
>   } AVIndexEntry;
>   
> -#define AV_DISPOSITION_DEFAULT   0x0001
> -#define AV_DISPOSITION_DUB       0x0002
> -#define AV_DISPOSITION_ORIGINAL  0x0004
> -#define AV_DISPOSITION_COMMENT   0x0008
> -#define AV_DISPOSITION_LYRICS    0x0010
> -#define AV_DISPOSITION_KARAOKE   0x0020
> +/**
> + * The stream should be chosen by default among other streams of the same time,
> + * unless the user has explicitly specified otherwise.
> + */
> +#define AV_DISPOSITION_DEFAULT              (1 << 0)
> +/**
> + * The stream is not in original language.
> + *
> + * @note AV_DISPOSITION_ORIGINAL is the inverse of this disposition. At most of
> + *       them should be set in properly tagged streams.
> + * @note This disposition may apply to any stream type, not just audio.
> + */
> +#define AV_DISPOSITION_DUB                  (1 << 1)

"At most of them" -> "At most one of them ..."?

Regards,
Tobias