[FFmpeg-devel] [PATCH v7 0/4] Add support for Matroska BlockAdditionMapping elements

quietvoid tcchlisop0 at gmail.com
Sun Nov 28 23:12:32 EET 2021


>
> This patch set adds support for reading/writing the Matroska BlockAdditionMapping
> elements, as well as for reading/writing dvcC/dvvC blocks in Matroska.
>
> Created utility functions to read/write Dolby Vision boxes for ISOM.
> This was done to avoid duplicating the code, as the Matroska blocks and MOV boxes
> follow the same specification, defined by Dolby.
>
> Refactored the reading/writing in mov/movenc to use the new dovi_isom functions.
>
> Differences compared to v6:
>   - Dropped the avformat/mpegts patch as suggested, because the specification
>     is different from the ISOM specification defined by Dolby.
>   - Added a patch to refactor avformat/movenc to further reduce the duplicated
>     code. The implementation in dovi_isom is the same.
>   - Moved init_put_bits after the size validation in ff_isom_put_dvcc_dvvc.
>   - Added dvwC to the ff_isom_put_dvcc_dvvc logging.
>
> quietvoid (4):
>   avformat/dovi_isom: Implement Dolby Vision configuration
>     parsing/writing
>   avformat/matroska{dec, enc}: Parse BlockAdditionMapping elements
>   avformat/mov: Refactor mov_read_dvcc_dvvc to use
>     ff_isom_parse_dvcc_dvvc
>   avformat/movenc: Refactor mov_write_dvcc_dvvc_tag to use
>     ff_isom_put_dvcc_dvvc
>
>  libavformat/Makefile      |   4 +-
>  libavformat/dovi_isom.c   | 121 ++++++++++++++++++++++++++++++++++++++
>  libavformat/dovi_isom.h   |  35 +++++++++++
>  libavformat/matroska.h    |   9 +++
>  libavformat/matroskadec.c |  58 +++++++++++++++++-
>  libavformat/matroskaenc.c |  45 ++++++++++++++
>  libavformat/mov.c         |  50 +++-------------
>  libavformat/movenc.c      |  26 +++-----
>  8 files changed, 286 insertions(+), 62 deletions(-)
>  create mode 100644 libavformat/dovi_isom.c
>  create mode 100644 libavformat/dovi_isom.h
>
>
Ping.

I've made a separate patch for regression tests for mov here:
https://patchwork.ffmpeg.org/project/ffmpeg/patch/20211126170534.2041327-1-tcChlisop0@gmail.com
The tests are all passing with the changes from this patch set.


More information about the ffmpeg-devel mailing list