[FFmpeg-devel] [PATCH] avformat/mov: reword log message about dref

Zhao Zhili quinkblack at foxmail.com
Thu Sep 2 11:26:56 EEST 2021


Most of the times it's just 'url ', so it's not unknown.
---
By the way, there is a patch to add support for dref.url
https://patchwork.ffmpeg.org/project/ffmpeg/patch/1596807454-17939-2-git-send-email-mypopydev@gmail.com/
I agree there are safety issues.

 libavformat/mov.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavformat/mov.c b/libavformat/mov.c
index c5583e07c7..c4024fc402 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -708,8 +708,8 @@ static int mov_read_dref(MOVContext *c, AVIOContext *pb, MOVAtom atom)
                     avio_skip(pb, len);
             }
         } else {
-            av_log(c->fc, AV_LOG_DEBUG, "Unknown dref type 0x%08"PRIx32" size %"PRIu32"\n",
-                   dref->type, size);
+            av_log(c->fc, AV_LOG_DEBUG, "Ignore dref type %s size %"PRIu32"\n",
+                   av_fourcc2str(dref->type), size);
             entries--;
             i--;
         }
-- 
2.31.1



More information about the ffmpeg-devel mailing list