[FFmpeg-devel] [PATCH 1/5] avcodec/libsvtav1: Fix redundant setting of caps_internal

[Andreas Rheinhardt]

lance.lmwang at gmail.com:
> From: Limin Wang <lance.lmwang at gmail.com>
> 
> Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
> ---
>  libavcodec/libsvtav1.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
> index fabc4e6..82ae2b9 100644
> --- a/libavcodec/libsvtav1.c
> +++ b/libavcodec/libsvtav1.c
> @@ -561,12 +561,11 @@ const AVCodec ff_libsvtav1_encoder = {
>      .receive_packet = eb_receive_packet,
>      .close          = eb_enc_close,
>      .capabilities   = AV_CODEC_CAP_DELAY | AV_CODEC_CAP_OTHER_THREADS,
> -    .caps_internal  = FF_CODEC_CAP_AUTO_THREADS,
> +    .caps_internal  = FF_CODEC_CAP_AUTO_THREADS | FF_CODEC_CAP_INIT_CLEANUP,
>      .pix_fmts       = (const enum AVPixelFormat[]){ AV_PIX_FMT_YUV420P,
>                                                      AV_PIX_FMT_YUV420P10,
>                                                      AV_PIX_FMT_NONE },
>      .priv_class     = &class,
>      .defaults       = eb_enc_defaults,
> -    .caps_internal  = FF_CODEC_CAP_INIT_CLEANUP,
>      .wrapper_name   = "libsvtav1",
>  };
> 
This is not redundant; the second initialization overrides the first. If
I read validate_thread_parameters in pthread.c correctly, this means
that 7d09579190d broke the ability to forward the threading parameters
to the actual encoder. But it never did this anyway, so it doesn't
matter. Should be fixed nevertheless.

- Andreas