[FFmpeg-devel] [PATCH] ffmpeg_filter: don't try to autorotate frames with hwaccel pixel formats
James Almer
jamrial at gmail.com
Tue Sep 21 15:32:54 EEST 2021
The transpose, rotate, hflip, and vflip filters don't support them.
Fixes ticket #9432.
Signed-off-by: James Almer <jamrial at gmail.com>
---
I'm surprised nobody tried to decode an mp4 video like those coming from a
cellphone camera using a hwaccel decoder. This would have been noticed much
earlier.
fftools/ffmpeg_filter.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c
index da0d4faf54..cc3dc33246 100644
--- a/fftools/ffmpeg_filter.c
+++ b/fftools/ffmpeg_filter.c
@@ -699,6 +699,7 @@ static int configure_input_video_filter(FilterGraph *fg, InputFilter *ifilter,
{
AVFilterContext *last_filter;
const AVFilter *buffer_filt = avfilter_get_by_name("buffer");
+ const AVPixFmtDescriptor *desc;
InputStream *ist = ifilter->ist;
InputFile *f = input_files[ist->file_index];
AVRational tb = ist->framerate.num ? av_inv_q(ist->framerate) :
@@ -756,7 +757,9 @@ static int configure_input_video_filter(FilterGraph *fg, InputFilter *ifilter,
av_freep(&par);
last_filter = ifilter->filter;
- if (ist->autorotate) {
+ desc = av_pix_fmt_desc_get(ifilter->format);
+ // TODO: insert hwaccel enabled filters like transpose_vaapi into the graph
+ if (ist->autorotate && desc && !(desc->flags & AV_PIX_FMT_FLAG_HWACCEL)) {
int32_t *displaymatrix = ifilter->displaymatrix;
double theta;
--
2.33.0
More information about the ffmpeg-devel
mailing list