[FFmpeg-devel] [PATCH v8 05/13] avfilter/sbuffer: Add sbuffersrc and sbuffersink filters

Soft Works softworkz at hotmail.com
Wed Sep 22 07:39:49 EEST 2021



> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Andreas
> Rheinhardt
> Sent: Wednesday, 22 September 2021 06:26
> To: ffmpeg-devel at ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v8 05/13] avfilter/sbuffer: Add sbuffersrc
> and sbuffersink filters
> 
> Soft Works:
> > Signed-off-by: softworkz <softworkz at hotmail.com>
> > ---
> >  configure                |  2 +-
> >  libavfilter/allfilters.c | 10 +++---
> >  libavfilter/buffersink.c | 63 +++++++++++++++++++++++++++++++++++
> >  libavfilter/buffersink.h | 15 +++++++++
> >  libavfilter/buffersrc.c  | 72 ++++++++++++++++++++++++++++++++++++++++
> >  libavfilter/buffersrc.h  |  1 +
> >  libavfilter/version.h    |  2 +-
> >  7 files changed, 159 insertions(+), 6 deletions(-)
> >
> > diff --git a/configure b/configure
> > index 231d0398a8..d18bb73ed6 100755
> > --- a/configure
> > +++ b/configure
> > @@ -7720,7 +7720,7 @@ print_enabled_components(){
> >          fi
> >      done
> >      if [ "$name" = "filter_list" ]; then
> > -        for c in asrc_abuffer vsrc_buffer asink_abuffer vsink_buffer; do
> > +        for c in asrc_abuffer vsrc_buffer ssrc_sbuffer asink_abuffer
> vsink_buffer ssink_sbuffer; do
> >              printf "    &ff_%s,\n" $c >> $TMPH
> >          done
> >      fi
> > diff --git a/libavfilter/allfilters.c b/libavfilter/allfilters.c
> > index ddd6404228..154eba5bb2 100644
> > --- a/libavfilter/allfilters.c
> > +++ b/libavfilter/allfilters.c
> > @@ -533,10 +533,12 @@ extern const AVFilter ff_avsrc_movie;
> >   * they are formatted to not be found by the grep
> >   * as they are manually added again (due to their 'names'
> >   * being the same while having different 'types'). */
> > -extern  const AVFilter ff_asrc_abuffer;
> > -extern  const AVFilter ff_vsrc_buffer;
> > -extern  const AVFilter ff_asink_abuffer;
> > -extern  const AVFilter ff_vsink_buffer;
> > +extern const AVFilter ff_asrc_abuffer;
> > +extern const AVFilter ff_vsrc_buffer;
> > +extern const AVFilter ff_ssrc_sbuffer;
> > +extern const AVFilter ff_asink_abuffer;
> > +extern const AVFilter ff_vsink_buffer;
> > +extern const AVFilter ff_ssink_sbuffer;
> >  extern const AVFilter ff_af_afifo;
> >  extern const AVFilter ff_vf_fifo;
> >
> 
> The awkward formatting here is intended; see the comment.
> (Haven't I already told you that?)

I'm carefully going over every single one of your comments
more than once, but I can't remember this one.
I apologize - If you mentioned it before I might have 
missed that e-mail.

Kind regards,
softworkz








More information about the ffmpeg-devel mailing list