[FFmpeg-devel] [PATCH v2 2/2] lavfi/overlay_vaapi: set defalut alpha value as 1.0

Fei Wang fei.w.wang at intel.com
Fri Aug 5 09:11:19 EEST 2022


The present default value of 0 will render the overlay video invisible.
A default of 1.0 is consistent with most common use cases.

Signed-off-by: Fei Wang <fei.w.wang at intel.com>
---
 doc/filters.texi               | 2 +-
 libavfilter/vf_overlay_vaapi.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/filters.texi b/doc/filters.texi
index a66b750d57..da0a946a6f 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
@@ -26170,7 +26170,7 @@ Default value is the height of input overlay video.
 @item alpha
 Set transparency of overlaid video. Allowed range is 0.0 to 1.0.
 Higher value means lower transparency.
-Default value is @code{0.0}.
+Default value is @code{1.0}.
 
 @end table
 
diff --git a/libavfilter/vf_overlay_vaapi.c b/libavfilter/vf_overlay_vaapi.c
index b3a624ae15..3e6a0de13f 100644
--- a/libavfilter/vf_overlay_vaapi.c
+++ b/libavfilter/vf_overlay_vaapi.c
@@ -380,7 +380,7 @@ static const AVOption overlay_vaapi_options[] = {
     { "h", "Overlay height",
       OFFSET(overlay_oh), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, INT_MAX, .flags = FLAGS },
     { "alpha", "Overlay global alpha",
-      OFFSET(alpha), AV_OPT_TYPE_FLOAT, { .dbl = 0.0}, 0.0, 1.0, .flags = FLAGS},
+      OFFSET(alpha), AV_OPT_TYPE_FLOAT, { .dbl = 1.0}, 0.0, 1.0, .flags = FLAGS},
     { NULL },
 };
 
-- 
2.25.1



More information about the ffmpeg-devel mailing list