[FFmpeg-devel] [PATCH] lswr: take const AVChannelLayout* in swr_alloc_set_opts2()

Anton Khirnov anton at khirnov.net
Sat Aug 6 16:19:10 EEST 2022


Quoting Anton Khirnov (2022-08-06 15:15:58)
> Quoting Andreas Rheinhardt (2022-08-06 13:50:37)
> > rcombs:
> > > This is fully backwards-compatible in both ABI and API,
> > > so it's only a minor bump.
> > 
> > It is not fully backwards-compatible API-wise: If you use a function
> > pointer for swr_alloc_set_opts2 by hardcoding its type, you will get
> > warnings now (or even errors depending upon your -Werror; it is an error
> > by default for C++). Given that I do not know about other language
> > bindings I have so far refrained from applying
> > https://patchwork.ffmpeg.org/project/ffmpeg/patch/AS1PR01MB95649A21F5F9A45D40E6AC1D8F1F9@AS1PR01MB9564.eurprd01.prod.exchangelabs.com/
> > This does not mean that I block your patch; to the contrary: If it
> > breaks nothing, I will apply the above patch after a month or so.
> 
> Maybe now could be a good time for a major bump, since we just had a
> release. It's also been two releases since the last one.

I would also love to finally get rid of FF_API_THREAD_SAFE_CALLBACKS

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list