[FFmpeg-devel] [PATCH] avcodec/pthread_frame: update the main avctx from the current, ThreadContext

[Steve Lhomme]

Hi,

On 2022-08-02 16:19, Anton Khirnov wrote:
> Why are you not resubmitting your original patch that stops copying
> hwaccel_priv_data to the user-facing context?
> 
> It seemed more correct to me, since the user-facing context should never
> see any hwaccel data. Or does it not fix the issue fully?

The original patch is not fixing it properly. With that patch and 
avcodec-threads > 1, the uninit of the hardware decoder is not called 
anymore. So it will replace a crash fix with a (big) resource leak.

For reference, this it the patch we're talking about
https://www.mail-archive.com/ffmpeg-devel@ffmpeg.org/msg94274.html

> For a more proper fix, we probably want to bundle hwaccel+state+uninit
> to a single refcounted thing.
> 
> -- 
> Anton Khirnov
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".