[FFmpeg-devel] [PATCH v1 03/13] lavc/hevc_ps: Add SPS/PPS parse support for HEVC extension syntax

[Michael Niedermayer]

On Thu, Dec 01, 2022 at 04:13:58PM +0800, Fei Wang wrote:
> From: Linjie Fu <linjie.fu at intel.com>
> 
> 1. Add extension syntax according to 7.3.2.2.3/7.3.2.3.3 in T-REC-H.265-201911.
> 2. Keep using parsed PPS when bitstream overread for compatibility. For
> example, the clip PS_A_VIDYO_3.bit in FATE test has incomplete extension
> syntax which will be overread and un-decodable if without this change.
> 3. Format brace in pps_range_extensions().
> 
> Signed-off-by: Linjie Fu <linjie.justin.fu at gmail.com>
> Signed-off-by: Haihao Xiang <haihao.xiang at intel.com>
> Signed-off-by: Fei Wang <fei.w.wang at intel.com>
> ---
>  libavcodec/hevc.h    |   3 +
>  libavcodec/hevc_ps.c | 293 +++++++++++++++++++++++++++++++++++++++++--
>  libavcodec/hevc_ps.h |  69 ++++++++++
>  3 files changed, 357 insertions(+), 8 deletions(-)

This causes segfaults

shortened stack trace looks like this, 
seems like classic stack overflow from infinite recursion

#0  0x0000555556403d10 in colour_mapping_octants ()
#1  0x0000555556403d15 in colour_mapping_octants ()
#2  0x0000555556403d15 in colour_mapping_octants ()
#3  0x0000555556403d15 in colour_mapping_octants ()
#4  0x0000555556403d15 in colour_mapping_octants ()
#5  0x0000555556403d15 in colour_mapping_octants ()
#6  0x0000555556403d15 in colour_mapping_octants ()
#7  0x0000555556403d15 in colour_mapping_octants ()
#8  0x0000555556403d15 in colour_mapping_octants ()
#9  0x0000555556403d15 in colour_mapping_octants ()
#10 0x0000555556403d15 in colour_mapping_octants ()
#11 0x0000555556403d15 in colour_mapping_octants ()
#12 0x0000555556403d15 in colour_mapping_octants ()
...


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20221202/9714f9a3/attachment.sig>