[FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime
Jeffrey CHAPUIS
ashyni1987 at gmail.com
Tue Dec 27 14:57:06 EET 2022
> You could just call ff_filter_process_command() instead of hardcoding
> supported commands here. It will ignore any option without the
> AV_OPT_FLAG_RUNTIME_PARAM flag.
> This is going to generate memleaks, and needlessly reallocate
> unrelated buffers.
> You should instead av_realloc all four s->bboxes buffers here, and
> reset s->limit.
I don't have knowledge in c/c++, I based my changes on vf_crop.c, but i
will look into your suggestions.
More information about the ffmpeg-devel
mailing list