[FFmpeg-devel] [PATCH] lavu: always provide symbols from hwcontext_vulkan.h
J. Dekker
jdek at itanimul.li
Tue Jul 5 15:20:53 EEST 2022
On 5 Jul 2022, at 2:11, Niklas Haas wrote:
> From: Niklas Haas <git at haasn.dev>
>
> This header is unconditionally installed, even though the utility
> functions defined by it may be missing from the built library.
>
> A precedent set by e.g. libavcodec/qsv.h (and others) is to always
> provide these functions by compiling stub functions in the absence of
> CONFIG_*. Make hwcontext_vulkan.h match this convention.
>
> Fixes downstream issues, e.g.
> https://github.com/haasn/libplacebo/issues/120
>
> Signed-off-by: Niklas Haas <git at haasn.dev>
> ---
> libavutil/Makefile | 2 +-
> libavutil/hwcontext_vulkan.c | 26 ++++++++++++++++++++++++--
> 2 files changed, 25 insertions(+), 3 deletions(-)
>
> [...]
Public API symbols (av_*) shouldn't completely disappear based on configure options.
LGTM.
--
J. Dekker
More information about the ffmpeg-devel
mailing list