[FFmpeg-devel] [PATCH 1/3] avcodec/lagarith: Check dst/src in zero run code

[Paul B Mahol]

On Tue, Jul 12, 2022 at 8:43 PM Michael Niedermayer <michael at niedermayer.cc>
wrote:

> Fixes: out of array access
> Fixes:
> 48799/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LAGARITH_fuzzer-4764457825337344
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by
> <https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by>:
> Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavcodec/lagarith.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/libavcodec/lagarith.c b/libavcodec/lagarith.c
> index 3aeb1c8a99..00e8005222 100644
> --- a/libavcodec/lagarith.c
> +++ b/libavcodec/lagarith.c
> @@ -409,6 +409,9 @@ output_zeros:
>          if (zero_run) {
>              zero_run = 0;
>              i += esc_count;
> +            if (i >  end - dst ||
> +                i >= src_end - src)
> +                return AVERROR_INVALIDDATA;
>              memcpy(dst, src, i);
>              dst += i;
>              l->zeros_rem = lag_calc_zero_run(src[i]);
>

LGTM


> --
> 2.17.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>